Merge changes from topic "separate_code"

* changes:
  soong: use -Wl,-z,separate-code w/ -Wl,--execute-only
  Revert "Revert "soong: upgrade Android platform to clang-r370808""
This commit is contained in:
Nick Desaulniers
2019-12-16 21:13:28 +00:00
committed by Gerrit Code Review
5 changed files with 24 additions and 4 deletions

View File

@@ -132,6 +132,10 @@ func init() {
// Disable -Winconsistent-missing-override until we can clean up the existing
// codebase for it.
"-Wno-inconsistent-missing-override",
// Warnings from clang-10
// Nested and array designated initialization is nice to have.
"-Wno-c99-designator",
}, " "))
pctx.StaticVariable("ClangExtraCppflags", strings.Join([]string{
@@ -161,6 +165,10 @@ func init() {
// new warnings are fixed.
"-Wno-tautological-constant-compare",
"-Wno-tautological-type-limit-compare",
// http://b/145210666
"-Wno-reorder-init-list",
// http://b/145211066
"-Wno-implicit-int-float-conversion",
}, " "))
// Extra cflags for external third-party projects to disable warnings that
@@ -176,6 +184,13 @@ func init() {
// Bug: http://b/29823425 Disable -Wnull-dereference until the
// new instances detected by this warning are fixed.
"-Wno-null-dereference",
// http://b/145211477
"-Wno-pointer-compare",
// http://b/145211022
"-Wno-xor-used-as-pow",
// http://b/145211022
"-Wno-final-dtor-non-final-class",
}, " "))
}

View File

@@ -126,8 +126,8 @@ var (
// prebuilts/clang default settings.
ClangDefaultBase = "prebuilts/clang/host"
ClangDefaultVersion = "clang-r365631b"
ClangDefaultShortVersion = "9.0.7"
ClangDefaultVersion = "clang-r370808"
ClangDefaultShortVersion = "10.0.1"
// Directories with warnings from Android.bp files.
WarningAllowedProjects = []string{

View File

@@ -261,6 +261,7 @@ func addStubLibraryCompilerFlags(flags Flags) Flags {
// We're knowingly doing some otherwise unsightly things with builtin
// functions here. We're just generating stub libraries, so ignore it.
"-Wno-incompatible-library-redeclaration",
"-Wno-incomplete-setjmp-declaration",
"-Wno-builtin-requires-header",
"-Wno-invalid-noreturn",
"-Wall",

View File

@@ -68,7 +68,10 @@ func (xom *xom) flags(ctx ModuleContext, flags Flags) Flags {
if !disableXom || (xom.Properties.Xom != nil && *xom.Properties.Xom) {
// XOM is only supported on AArch64 when using lld.
if ctx.Arch().ArchType == android.Arm64 && ctx.useClangLld(ctx) {
flags.Local.LdFlags = append(flags.Local.LdFlags, "-Wl,-execute-only")
flags.Local.LdFlags = append(flags.Local.LdFlags,
"-Wl,--execute-only",
"-Wl,-z,separate-code",
)
}
}

View File

@@ -27,7 +27,8 @@ var (
"-Wl,--icf=safe",
"-Wl,-z,max-page-size=4096",
"-Wl,-execute-only",
"-Wl,--execute-only",
"-Wl,-z,separate-code",
}
Arm64ArchVariantRustFlags = map[string][]string{