Fix: deps to sanitizer runtime libs are with correct 'image' variant am: 3b1746a212

am: dc9872a0d3

Change-Id: I53c6b3a08b1c7e5a2a16e88e202d2eee3989567e
This commit is contained in:
Jiyong Park
2019-01-30 09:34:29 -08:00
committed by android-build-merger
2 changed files with 15 additions and 9 deletions

View File

@@ -1175,15 +1175,9 @@ func (c *Module) DepsMutator(actx android.BottomUpMutatorContext) {
depTag = headerExportDepTag depTag = headerExportDepTag
} }
if buildStubs { if buildStubs {
imageVariation := "core"
if c.useVndk() {
imageVariation = "vendor"
} else if c.inRecovery() {
imageVariation = "recovery"
}
actx.AddFarVariationDependencies([]blueprint.Variation{ actx.AddFarVariationDependencies([]blueprint.Variation{
{Mutator: "arch", Variation: ctx.Target().String()}, {Mutator: "arch", Variation: ctx.Target().String()},
{Mutator: "image", Variation: imageVariation}, {Mutator: "image", Variation: c.imageVariation()},
}, depTag, lib) }, depTag, lib)
} else { } else {
actx.AddVariationDependencies(nil, depTag, lib) actx.AddVariationDependencies(nil, depTag, lib)
@@ -1845,6 +1839,16 @@ func (c *Module) IsInstallableToApex() bool {
return false return false
} }
func (c *Module) imageVariation() string {
variation := "core"
if c.useVndk() {
variation = "vendor"
} else if c.inRecovery() {
variation = "recovery"
}
return variation
}
// //
// Defaults // Defaults
// //

View File

@@ -787,7 +787,7 @@ func sanitizerRuntimeMutator(mctx android.BottomUpMutatorContext) {
} }
if mctx.Device() && runtimeLibrary != "" { if mctx.Device() && runtimeLibrary != "" {
if inList(runtimeLibrary, llndkLibraries) && !c.static() { if inList(runtimeLibrary, llndkLibraries) && !c.static() && c.useVndk() {
runtimeLibrary = runtimeLibrary + llndkLibrarySuffix runtimeLibrary = runtimeLibrary + llndkLibrarySuffix
} }
@@ -802,12 +802,14 @@ func sanitizerRuntimeMutator(mctx android.BottomUpMutatorContext) {
// static executable gets static runtime libs // static executable gets static runtime libs
mctx.AddFarVariationDependencies([]blueprint.Variation{ mctx.AddFarVariationDependencies([]blueprint.Variation{
{Mutator: "link", Variation: "static"}, {Mutator: "link", Variation: "static"},
{Mutator: "image", Variation: c.imageVariation()},
{Mutator: "arch", Variation: mctx.Target().String()}, {Mutator: "arch", Variation: mctx.Target().String()},
}, staticDepTag, runtimeLibrary) }, staticDepTag, runtimeLibrary)
} else if !c.static() { } else if !c.static() {
// dynamic executable andshared libs get shared runtime libs // dynamic executable and shared libs get shared runtime libs
mctx.AddFarVariationDependencies([]blueprint.Variation{ mctx.AddFarVariationDependencies([]blueprint.Variation{
{Mutator: "link", Variation: "shared"}, {Mutator: "link", Variation: "shared"},
{Mutator: "image", Variation: c.imageVariation()},
{Mutator: "arch", Variation: mctx.Target().String()}, {Mutator: "arch", Variation: mctx.Target().String()},
}, earlySharedDepTag, runtimeLibrary) }, earlySharedDepTag, runtimeLibrary)
} }