Commit Graph

5824 Commits

Author SHA1 Message Date
Colin Cross
20b350b433 Merge "Use android.InList for inList"
am: e35ad13004

Change-Id: I6a712813ed3294b3e5a0365f09675e430211f4d9
2018-02-22 03:55:36 +00:00
Treehugger Robot
e35ad13004 Merge "Use android.InList for inList" 2018-02-22 03:22:43 +00:00
Colin Cross
1dc37ea7ca Merge "Use __SBOX_OUT_DIR__ in sbox output file list"
am: 431e17af07

Change-Id: I3e2b677a555bd6ced13e9dea688fe6c3980bf1b1
2018-02-22 02:05:56 +00:00
Treehugger Robot
431e17af07 Merge "Use __SBOX_OUT_DIR__ in sbox output file list" 2018-02-22 01:59:09 +00:00
Colin Cross
baccf5b984 Use __SBOX_OUT_DIR__ in sbox output file list
The path to the output directory may be arbitrarily long, use
__SBOX_OUT_DIR__ in the list of output files passed to sbox
to avoid expanding it multiple times in the command line.

Fixes:
ninja: fatal: posix_spawn: Argument list too long
09:40:14 ninja failed with: exit status 1
when building libchrome with a long OUT or OUT_DIR_COMMON_BASE.

Bug: 73726635
Test: m checkbuild
Change-Id: I59024b2164287c8e531711afd9273b692ce9c28a
2018-02-21 14:55:34 -08:00
Colin Cross
0d0ba59ec3 Use android.InList for inList
Remove duplicate implementations of inList.

Test: m checkbuild
Change-Id: I6943b95f6d47e6722b9ff1ab61ab14c429fe33a0
2018-02-21 11:02:16 -08:00
Jayant Chowdhary
6bbac8082f Merge "Start using clang-tools prebuilts for abi diffing tools."
am: b49ff309a1

Change-Id: Idf7ae900c76a26eb9068c99b61c11e3de65297bf
2018-02-21 18:28:05 +00:00
Jayant Chowdhary
b49ff309a1 Merge "Start using clang-tools prebuilts for abi diffing tools." 2018-02-21 18:16:02 +00:00
Jiyong Park
d5f4f45505 Merge "Only emit enabled VNDK libraries"
am: d240e3d4e2

Change-Id: Icdaf1d506a1e8a52972c07f7e953878c664c58c8
2018-02-21 02:51:26 +00:00
Treehugger Robot
d240e3d4e2 Merge "Only emit enabled VNDK libraries" 2018-02-21 02:35:31 +00:00
Jayant Chowdhary
a4c6df5d69 Start using clang-tools prebuilts for abi diffing tools.
Bug: 72504455

Test: make -j64

Change-Id: Idbe1142e11147163d0c032fb351e9f3d5614dfb1
2018-02-20 12:44:50 -08:00
Colin Cross
e5f32c8091 Fix injecting data into a .o file
am: 52226ad920

Change-Id: I742e9ffe508d06d1d9f5763f8bdbff2fc844e759
2018-02-20 18:07:10 +00:00
Colin Cross
a14eee8e4a Fix comment on how java rules handle unknown output files
am: f7eac7a2ac

Change-Id: I6fb9e3404055fca835834b6e4b1e52d3a6e3c4fd
2018-02-20 18:06:44 +00:00
Colin Cross
52226ad920 Fix injecting data into a .o file
Use section.Offset instead of Addr.

Test: symbol_inject -i test.o -o test2.o -s symbol -v value
Change-Id: I9c54a5a245e7674b8370fc27ba7d0b9995f2ed08
2018-02-20 17:54:20 +00:00
Colin Cross
f7eac7a2ac Fix comment on how java rules handle unknown output files
Test: none
Change-Id: I985e7961c87dd145d6eb2bd94cb8bdc43becc360
2018-02-20 17:54:00 +00:00
Elliott Hughes
6dc655202b Use the platform -std= for sdk_version.
am: 5789ca9f28

Change-Id: I0b7130226d62f7d1d9c2c5eb6bddecf546323094
2018-02-20 15:37:13 +00:00
Elliott Hughes
5789ca9f28 Use the platform -std= for sdk_version.
Bug: http://b/72571399
Test: builds
Change-Id: I294cfadb7de54b1ae648e02ac9af34ed7a7405d8
2018-02-20 15:27:45 +00:00
Nan Zhang
3aa79ee5f5 Merge "Revert "Revert "Support filegroup in exclude_srcs"""
am: f28e32a2a5

Change-Id: I0d2e026e1ee01ecac5bf06c379b325e431b0ac2e
2018-02-19 18:23:03 +00:00
Treehugger Robot
f28e32a2a5 Merge "Revert "Revert "Support filegroup in exclude_srcs""" 2018-02-19 18:14:37 +00:00
Jiyong Park
4b0322265f Only emit enabled VNDK libraries
Disabled VNDK libraries (due to arch mismatch) are no longer emitted to
make variables VNDK_CORE_LIBRARIES and LLNDK_LIBRARIES

Bug: 7456955
Test: choosecombo to aosp_walleye and m -j
Find libclang_rt.ubsan_standalone-<arch>-android in VNDK_CORE_LIBRARIES.
Only aarch64 and arm are found.

Change-Id: Iaa134d07513e39390fe34a31fdfe2e327b190996
2018-02-16 22:16:29 +09:00
Yi Kong
db764c0315 Merge "Disable inlining and loop unrolling in LTO without PGO profile"
am: 06d1060041

Change-Id: Ie5aa4f6fa3abb10453e900a7be298d418688ab60
2018-02-16 03:13:07 +00:00
Yi Kong
06d1060041 Merge "Disable inlining and loop unrolling in LTO without PGO profile" 2018-02-16 02:46:36 +00:00
Nan Zhang
cb33597d5a Let Soong_UI to handle build_date.txt file
am: 2e6a4ff3be

Change-Id: Ib19d02398a54e7eee5424ae04f9eb1bede132001
2018-02-15 22:46:36 +00:00
Nan Zhang
27e284d2b0 Revert "Revert "Support filegroup in exclude_srcs""
This reverts commit 606e9de344.

Reason for revert: <try to fix the broken build yesterday>

Change-Id: I2963b9af63c7c7398159e5e9a1e448266e1c81d5
Test: unittest
2018-02-15 14:38:40 -08:00
Nan Zhang
2e6a4ff3be Let Soong_UI to handle build_date.txt file
Soong_UI will update timestamp to build_date.txt, and export variables
to kati/ninja.

Test: m -j32
Bug: b/70351683
Change-Id: I153897afdf2d3f39a32d757d4c3ae7515caea52d
2018-02-15 11:45:53 -08:00
Przemyslaw Szczepaniak
dae5bb8f25 Add rsp and srcjar support to kotlinc build rule
am: 4b5fe9d1b4

Change-Id: Id28939fd29103701af2d24f5e56fad27b66582d3
2018-02-15 11:49:39 +00:00
Przemyslaw Szczepaniak
4b5fe9d1b4 Add rsp and srcjar support to kotlinc build rule
Rsp files are supported through helper script (gen-kotlin-build-file.sh)
that generates the kotlinc module/build xml file.

Since rsp files are supported, I've added ExtractSrcJarsCmd step
to handle srcjars extraction.

Minor reorderings to make sure that TransformKotlinToClasses
recives only .java and .kt files when called from Module.compile.

Bug: 73281388
Test: make -j hidl-doc
Change-Id: I5a40b914569018dc529903a7f2864a5aeae838e5
2018-02-14 20:47:17 +00:00
Zhizhou Yang
5f4c0d6cb3 Fix llvm-ar error caused by using lto and sanitizer together
am: 51be632b95

Change-Id: I3f66259e36671facce563b1a50814e7306513414
2018-02-14 18:38:54 +00:00
Yi Kong
7e53c57ed6 Disable inlining and loop unrolling in LTO without PGO profile
Such optimisations may significantly increase the binary size when
compiler heuristics are off. Disabling these helps cut down the
binary sizes with negligible decrease in performance, but allows us to
be more comfortable enabling LTO across various projects.

Test: m
Test: dex2oat, hwui, skia benchmark
Bug: 62839002
Change-Id: Id63e8dd295df2972f76ae4e29ee367080fff8429
2018-02-14 21:21:23 +08:00
Zhizhou Yang
51be632b95 Fix llvm-ar error caused by using lto and sanitizer together
LLVM-AR does not allow passing --plugin options more than once. The
--plugin ARFLAGS that lto want to add, may already exist if sanitizer is
also turned on.

Fixed this by adding a new bool Flags.ArGoldPlugin. Set this variable to
true whenever LLVM gold plugin is needed for ArFlags. In function
TransformObjToStaticLib(), add this option to arFlags using global value
${config.LLVMGoldPlugin} if the bool value is true.

Bug: http://b/73160350
Test: build the image with make and succeeded.

Change-Id: I62785829b0a4b663225926e4aed98defc1b6da2c
(cherry picked from commit 4917049f6e)
2018-02-14 21:21:14 +08:00
Nan Zhang
afe289114a Merge "Add Respfile support for soong_zip."
am: 3bb5f2f2fa

Change-Id: Ifc59ddbd16a5cf82f7750f9927c2d0f24627fc81
2018-02-14 01:14:08 +00:00
Treehugger Robot
3bb5f2f2fa Merge "Add Respfile support for soong_zip." 2018-02-14 01:04:22 +00:00
Alan Viverette
3420beb522 Merge "Use "jar" as default type, "compile" as default scope"
am: 1fd468782a

Change-Id: Ic9060c251e4927c336fc9f176518ceff3fbe85d6
2018-02-13 23:24:09 +00:00
Treehugger Robot
1fd468782a Merge "Use "jar" as default type, "compile" as default scope" 2018-02-13 23:17:02 +00:00
Nan Zhang
674dd932d8 Add Respfile support for soong_zip.
Sometime the size of our command line passed to soong_zip go program
exceeds the cmdline size limit. So add an RespFile support with "@" special
character prefix.

The args in the cmdline will be considered together with the
args in RespFile during soong_zip running.

Test: real tests in my local machine, and compare the
res/libphonenumber.jar before and after changes.

./cmd -o test.zip '""'-C -> [./cmd,-o,test.zip,""-C]
./cmd -o test.zip '-C -f -> [./cmd,-o,test.zip,-C -f]
./cmd -o test.zip '\"'-C -f -> [./cmd,-o,test.zip,\"-C -f]
./cmd -o test.zip '\\'-C -f -> [./cmd,-o,test.zip,\\-C -f]
./cmd -o test.zip '\a'-C -f -> [./cmd,-o,test.zip,\a-C -f]

./cmd -o test.zip \'-C -> [./cmd,-o,test.zip,'-C]
./cmd -o test.zip \\-C -> [./cmd,-o,test.zip,\-C]
./cmd -o test.zip \"-C -> [./cmd,-o,test.zip,"-C]

./cmd -o test.zip "'"-C -> [./cmd,-o,test.zip,'-C]
./cmd -o test.zip "\\"-C -f -> [./cmd,-o,test.zip,\a-C -f]
./cmd -o test.zip "\""-C -f -> [./cmd,-o,test.zip,"a-C -f]

Bug: b/72484223

Change-Id: I83c3630b70c8396c8e8a3f266244d868d754c4e8
2018-02-13 15:13:01 -08:00
Pirama Arumuga Nainar
8f7ea0ebdd Search for PGO profiles in PGO_ADDITIONAL_PROFILE_DIRS
am: 49540800f0

Change-Id: Ia182ff5272cf4f42fde7a6d96a48076c1998a98e
2018-02-13 21:03:44 +00:00
Alan Viverette
6bd35eb6f5 Use "jar" as default type, "compile" as default scope
Only include dependencies for scope "compile."

Bug: 73263586
Test: ./update_current.py -s -t <build-id>
Change-Id: I2ac6055cb4c1ad1f8d7924869f54f50e5e662742
2018-02-13 15:21:18 -05:00
Pirama Arumuga Nainar
49540800f0 Search for PGO profiles in PGO_ADDITIONAL_PROFILE_DIRS
This variable can be set in BoardConfig.mk to specify a list of
additional paths that contain PGO profiles.  These directories are
searched after the predefined paths in soong/cc/pgo.go while finding
PGO profiles.

Test: Set this variable in a BoardConfig and verify that such profiles
are found and that these paths are searched after the predefined paths
in soong/cc/pgo.go.

Change-Id: I0bb9523de614d0f23aba8d51c887d8fc8f41c993
2018-02-13 09:41:13 -08:00
Dan Albert
b4e2a566f9 Merge "Disable a warning that libc++'s headers trip."
am: 1d29875829

Change-Id: I4c7c14f2634dcda7edf6f5348654fd3094f71881
2018-02-09 18:38:01 +00:00
Treehugger Robot
1d29875829 Merge "Disable a warning that libc++'s headers trip." 2018-02-09 18:23:11 +00:00
Tobias Thierer
62c06ce8ed Merge "Revert "Support filegroup in exclude_srcs""
am: f5801db4cc

Change-Id: I180101b7d1a0eeef10a1ca4bfc4198262b80c001
2018-02-09 10:07:15 +00:00
Tobias Thierer
f5801db4cc Merge "Revert "Support filegroup in exclude_srcs"" 2018-02-09 09:56:59 +00:00
Tobias Thierer
606e9de344 Revert "Support filegroup in exclude_srcs"
This reverts commit f36a3d9b6d.

Reason for revert: Broke several builds. I'm acting build cop, reverting.

Bug: 70351683

Change-Id: I775ada4e9cb6473519d51420b41b818af163da44
2018-02-09 09:46:11 +00:00
Nan Zhang
4357144070 Merge "Support filegroup in exclude_srcs"
am: a9e0fabae1

Change-Id: Iedf085da401f2ded29137b624141d7971684b38d
2018-02-09 06:55:46 +00:00
Treehugger Robot
a9e0fabae1 Merge "Support filegroup in exclude_srcs" 2018-02-09 06:49:28 +00:00
Colin Cross
c40d9b1e7f Disable duplicates warnings when merging jars
am: f91a08caca

Change-Id: I722984453c53cedf77cea8493c7185b8c8c6756d
2018-02-08 08:51:58 +00:00
Dan Albert
f2ceea7f1f Disable a warning that libc++'s headers trip.
Test: make checkbuild
Bug: None
Change-Id: I117bd9ef3f4f3c8792f4b6692d7b70ad69b6922d
2018-02-07 17:24:42 -08:00
Colin Cross
f91a08caca Disable duplicates warnings when merging jars
There are too many duplicates warnings, disable them until someone
is actually looking at them.

Bug: 69316739
Test: m checkbuild
Change-Id: I7b3315f999dff1c01b6df37ab5ca83f7b8a60bd9
2018-02-08 01:15:39 +00:00
Dan Willemsen
5f45e9b1a6 Add performance and best practices documentation
am: bc203622e6

Change-Id: I2901750a907cfb141cfea33419ae7b6928c22663
2018-02-07 21:08:03 +00:00
Nan Zhang
f36a3d9b6d Support filegroup in exclude_srcs
Test: add unit-test, m -j32
Bug: b/70351683
Change-Id: Iff83c56d45dd668d9df6131c7df2e23e5c73a21b
2018-02-07 10:18:41 -08:00