Commit Graph

6271 Commits

Author SHA1 Message Date
Jiyong Park
2ae570eb6c Merge "java_sdk_library does the apicheck by default"
am: a8d897cc49

Change-Id: I9f8759bd94a4cd051946db1d750285cf78fc551b
2018-05-14 23:55:35 -07:00
Jiyong Park
a8d897cc49 Merge "java_sdk_library does the apicheck by default" 2018-05-15 05:30:41 +00:00
Dan Willemsen
e81e414fd6 Merge "Handle readonly directories in tmpdir"
am: 2eb7e2135c

Change-Id: I7d65ebc9da7581ad39cc495416fc188bf0c30687
2018-05-14 21:51:19 -07:00
Treehugger Robot
2eb7e2135c Merge "Handle readonly directories in tmpdir" 2018-05-15 04:38:19 +00:00
Dan Willemsen
fe8b6453a7 Handle readonly directories in tmpdir
Some tests make their temporary directories readonly. If they fail or
crash before cleaning up, they could leave these readonly directories
behind with files in them. os.RemoveAll fails with an error in this
case, and we can't start the build until they're removed.

Test: `m blueprint_tools` to run the new go tests
Change-Id: I761f96579e96167ebfd98c6cca59765bd50536ec
2018-05-14 19:44:54 -07:00
Jiyong Park
58c518b594 java_sdk_library does the apicheck by default
droiddoc now supports apicheck. java_sdk_library uses it to
automatically perform apichecks against the not-yet-release API and
the latest-released API.

A module type prebuilt_apis is added. It finds api txt files and creates
filegroup modules so that it can be referenced from java_sdk_library
across the module boundary.

Bug: 77575606
Test: m -j
Test: m -j checkapi
Test: m -j update-api
Change-Id: I0ba859972eac060296e1df2e71c4e047392d4877
2018-05-15 10:57:01 +09:00
Dan Willemsen
25c0624dcb Merge changes I61fdd945,I746a00a3
am: 5473c9a60a

Change-Id: Ied629f7d2de8cdeb45e46de6263ee9468dd7374a
2018-05-14 17:17:01 -07:00
Treehugger Robot
5473c9a60a Merge changes I61fdd945,I746a00a3
* changes:
  bpfix: Convert local_include_dirs removal to PatchList
  bpfix: Add reorderCommonProperties
2018-05-15 00:08:08 +00:00
Jayant Chowdhary
516bc12773 Merge "Allow abi diffs sanitized variants of vndk libraries on production devices."
am: ce617bbbdb

Change-Id: I9638b92af5cf9fbc87ebf4076c4a8ff84a56a540
2018-05-14 17:06:01 -07:00
Jayant Chowdhary
ce617bbbdb Merge "Allow abi diffs sanitized variants of vndk libraries on production devices." 2018-05-14 23:54:49 +00:00
Dan Willemsen
2b21a77ad9 bpfix: Convert local_include_dirs removal to PatchList
This way we can remove the line the property was on, not just the
property itself.

Test: `m blueprint_tools` to run the unit tests
Test: diff bpfix results on all of AOSP before/after this change
Change-Id: I61fdd945e6ee711c620b79683dfee7b7c751b3c4
2018-05-14 15:32:21 -07:00
Dan Willemsen
36c69ee42b bpfix: Add reorderCommonProperties
This will move the common properties:

  name
  defaults
  device_supported
  host_supported

To be listed first (and in that order) for every module. Other
properties are untouched.

This also adds a helper to test individual passes in an end-to-end
manner, and a helper to run passes that use PatchLists.

Test: `m blueprint_tools` to add the new tests
Test: Diff bpfix results over all of aosp before/after this change
Change-Id: I746a00a3731cb7597d2613ef2dc45a99654cd122
2018-05-14 15:32:21 -07:00
Jiyong Park
87e61f5667 Fix some minor bugs for droiddoc
am: eeb8a6474c

Change-Id: I018c1c119e72a763aa70e90ede5e3bbaecde6242
2018-05-13 19:26:50 -07:00
Jiyong Park
eeb8a6474c Fix some minor bugs for droiddoc
1) typo: check-api -> checkapi
2) newlines in the error messages are correctly emitted

Bug: 77575606
Bug: 78034256
Test: m -j checkapi

Change-Id: Ibeef4d9f4f7f2ca48c29c23b1784efa6aa53a364
2018-05-12 22:22:34 +09:00
Christopher Ferris
c6752f63e3 Merge "Add support for cortex-a55/cortex-a75."
am: 9623892890

Change-Id: Idb9b0455815d7d07a4d4ced04f4ee77bba84ff5d
2018-05-11 11:08:27 -07:00
Christopher Ferris
9623892890 Merge "Add support for cortex-a55/cortex-a75." 2018-05-11 17:56:12 +00:00
Elliott Hughes
c5933395cd Flounder's been dead so long it smells.
am: 314fddbfc6

Change-Id: I29e991298c63a1d881331d3209d52deba0d784f3
2018-05-10 18:49:56 -07:00
Christopher Ferris
ba14a8f4bb Add support for cortex-a55/cortex-a75.
Bug: 78133793
Bug: 78242072

Test: Builds when using cortex-a75 as a target.
Change-Id: Ie3fbe40b15f4d89eeba0d630a82097122fc83b33
Merged-In: Ie3fbe40b15f4d89eeba0d630a82097122fc83b33
(cherry picked from commit 0612597a41)
2018-05-11 00:43:39 +00:00
Jayant Chowdhary
b7e08ca830 Allow abi diffs sanitized variants of vndk libraries on production devices.
Previously abi diffs were allowed only on unsanitized variants of vndk
libraries. This CL allows them on all sanitized variants which go onto
production devices, eg: cfi variants.

Bug: 66301104

Test: Without this change, for arm64 libstagefright_foundation doesn't
      get an lsdump file since we don't build an unsanitized variant
      (aosp_arm64_ab).

Test: With this change, for arm64 libstagefright_foundation does
      get an lsdump file (aosp_arm64_ab)

Change-Id: I94f82fd84fc898e4980c3f3619df9677ed723c32
2018-05-10 15:32:18 -07:00
Elliott Hughes
314fddbfc6 Flounder's been dead so long it smells.
(And confuses people when it shows up in NDK build failures in 2018.)

Bug: N/A
Test: builds
Change-Id: Ie055b17d1c4bd7c8b73f10adcc7f7b784f9e9c91
2018-05-10 13:55:30 -07:00
Colin Cross
27af6ec339 Merge "Pass platform version name as --version-name for framework-res.apk"
am: 94a95e1348

Change-Id: I752af5a5454bc3f57e48d8567df9bdc83047cbfd
2018-05-09 18:00:19 -07:00
Treehugger Robot
94a95e1348 Merge "Pass platform version name as --version-name for framework-res.apk" 2018-05-10 00:54:12 +00:00
yangbill
70ccb36e75 Merge "Build System: Fix rpath error if native executable under testcase folder."
am: cfedb7bdb3

Change-Id: I04b5b6748c40d63d418a3a3782048324b5aa9660
2018-05-09 17:52:38 -07:00
Treehugger Robot
cfedb7bdb3 Merge "Build System: Fix rpath error if native executable under testcase folder." 2018-05-10 00:41:27 +00:00
Colin Cross
bfd347dc82 Pass platform version name as --version-name for framework-res.apk
framework-res.apk should get the platform version name ("9") as
--version-name, not the SDK version ("28").  It will get copied
to compileSdkVersionCodename in APKs compiled against it.

Bug: 78324052
Test: aapt dump badging $OUT/system/framework/framework-res.apk | grep -i version
Change-Id: I34a601cb2c14f66199066e7d598862108da0b950
Merged-In: I34a601cb2c14f66199066e7d598862108da0b950
(cherry picked from commit b691e24d89)
2018-05-09 15:56:46 -07:00
android-build-prod (mdb)
2658508416 Merge "Apicheck Support in Soong"
am: 3a621d3a86

Change-Id: I6158968bf4ca95301dc896bec8a1906303656d25
2018-05-08 23:05:19 -07:00
android-build-prod (mdb)
3a621d3a86 Merge "Apicheck Support in Soong" 2018-05-09 05:58:00 +00:00
Tri Vo
368e0ab5a2 Merge "Expose selinux variables to Soong."
am: c5934c55c7

Change-Id: I5de6ed34ea485d3c46bd7d719a30d62b853395fd
2018-05-08 19:09:35 -07:00
Tri Vo
c5934c55c7 Merge "Expose selinux variables to Soong." 2018-05-09 01:57:14 +00:00
Nan Zhang
61819cef14 Apicheck Support in Soong
didn't remove the props: api_filename, removed_api_filename yet since
these two currently are used by java_sdk_library.

Bug: b/78034256
Test: m clean && m checkapi

Change-Id: Iebd014ef227487717b5b3819c80d630c34559983
2018-05-08 16:24:07 -07:00
Yi Kong
9522351748 Merge "Take Enable_profile_use into account when checking if PGO is enabled"
am: ea144bf779

Change-Id: I4a00ba6be397a32346fea1785c85c3d4f3cd2f31
2018-05-08 12:47:08 -07:00
Yi Kong
ea144bf779 Merge "Take Enable_profile_use into account when checking if PGO is enabled" 2018-05-08 19:37:29 +00:00
android-build-prod (mdb)
263532199c Merge "Don't install modules in unexported namespaces"
am: bd1dd19c3a

Change-Id: Id3c784619c402e1d5ccb882cbf2e4f3dd2deaa46
2018-05-08 11:37:46 -07:00
android-build-prod (mdb)
bd1dd19c3a Merge "Don't install modules in unexported namespaces" 2018-05-08 18:23:59 +00:00
android-build-prod (mdb)
d2bb2b5c6c Merge changes I52f88bfd,I4263b7d5
am: 720f04b964

Change-Id: I3784821ee5b4b3d51fba17e240d56cd553a986f4
2018-05-07 18:16:00 -07:00
android-build-prod (mdb)
720f04b964 Merge changes I52f88bfd,I4263b7d5
* changes:
  Fix usage of bytes.NewBuffer in bpfix
  Add a dependency fixer for proto deps
2018-05-08 01:05:10 +00:00
Dan Willemsen
00bdceee3f bpfix: Remove local_include_dirs if we remove the last entry
am: dde8cb9615

Change-Id: I7a5e267dd946f266e6c450d8f00c4f5d7bccb094
2018-05-07 16:43:17 -07:00
Dan Willemsen
d6989f2e52 Fix usage of bytes.NewBuffer in bpfix
According to the documentation: "NewBuffer creates and initializes a new
Buffer using buf as its initial contents. The new Buffer takes ownership
of buf, and the caller should not use buf after this call."

Test: Run bpfix twice, only wrote the first time.
Change-Id: I52f88bfd9247240436b46f396c9196157774615b
2018-05-07 16:22:22 -07:00
Dan Willemsen
4339853a20 Add a dependency fixer for proto deps
protoc dependency files, at least for C++ outputs, uses the form of:

  a/b.c \
  a/b.h: <dep1> <dep2>...

Ninja will fail the command when it parses a dep file and there's more
than one output file (even though it doesn't care what the output file
name is). So this tool will parse the original file, and output a
version with only a single output file.

Bug: 67329638
Test: NINJA_ARGS="-t deps ...pb.c" m
Test: NINJA_ARGS="-t deps ...srcjar" m
Test: NINJA_ARGS="-t deps ...srcszip" m
Test: Run dep_fixer across all of taimen's dep files, no failures.
Test: Run dep_fixer against the processed files, no changes.
Test: Run androidmk across all of our Android.mk files, inspect the diffs
Change-Id: I4263b7d5faea37285afa6b24dedf5964aa7d19dc
2018-05-07 16:21:59 -07:00
Colin Cross
3607f21303 Don't install modules in unexported namespaces
Make builds handle modules with duplicate names in different
namespaces by passing a list of exported namespaces to Soong.
Soong-only builds can try to install both modules, leading to
a duplicate rule error.  Re-use the same list of exported
namespaces in Soong, which will be empty in all existing
Soong-only builds.  This will effectively only install modules
in the root namespace in Soong-only builds.

Test: m checkbuild
Bug: 79369665
Change-Id: Ie80d4b77e1dce165a33579fcf58b571989794b35
2018-05-07 15:28:05 -07:00
Yi Kong
ca610d2be4 Take Enable_profile_use into account when checking if PGO is enabled
Test: m
Change-Id: I3c589043af145450d0d97ef354a74845e9fae483
2018-05-07 15:16:36 -07:00
Dan Willemsen
dde8cb9615 bpfix: Remove local_include_dirs if we remove the last entry
This still leaves a blank line in it's place, but that's a more general
problem.

Test: m blueprint_tools
Test: Run bpfix over AOSP, diff.
Change-Id: I55c1d1c183cfa49beeca07abd539348bc2524c5a
2018-05-07 13:32:09 -07:00
Colin Cross
84d9a35b32 Merge "Export lists of support libraries modules to Make"
am: 028f42f002

Change-Id: I02fee5019d9bd8efc990c510c6f673905056c1ef
2018-05-07 12:09:32 -07:00
Colin Cross
028f42f002 Merge "Export lists of support libraries modules to Make" 2018-05-07 17:53:09 +00:00
yangbill
b3174d190e Build System: Fix rpath error if native executable under testcase folder.
error while loading shared libraries: libc++.so:
cannot open shared object file: No such file or directory

BUG: N/A
Test: make -j16 hello_world_test
      out/host/linux-x86/testcases/hello_world_test/x86_64/hello_world_test
      out/host/linux-x86/testcases/hello_world_test/x86/hello_world_test

Change-Id: I0ecb1955cd67295abe12fc19ab811fe046ac5f23
2018-05-07 07:46:16 +00:00
Jiyong Park
35a9bfd238 Prevent index out of range
am: b674a5226a

Change-Id: Ie518981659c3aea595bac9c4b4bc12bfe332fc1a
2018-05-05 17:35:29 -07:00
Jiyong Park
b674a5226a Prevent index out of range
I3487634f1ec5bb3b5b60d636b64461d391add35a is causing build breakages in
unbundled builds.

The stubs libs are disabled for unbundled builds, and thus we shouldn't
declare them as dist artifacts.

Bug: 605033
Test: make -j dist ANDROID_BUILDSPEC=vendor/google/build/app_build_spec.mk
Change-Id: I3cd92e2cc6aeb48baf47d37780d8df2aa4756438
2018-05-06 07:56:17 +09:00
Dan Willemsen
de96707de0 Fix androidmk converting cc libraries
am: 75dec2291b

Change-Id: I6bf4eeee35b8a6939ed7eb6c9061e0a4a0fb1f4d
2018-05-05 15:19:01 -07:00
Dan Willemsen
75dec2291b Fix androidmk converting cc libraries
The java library rewrites should only happen for java modules, not cc
modules.

Test: Ran androidmk on a number of Android.mk files
Change-Id: Ife2cfb5a69d7db37216671f08317033b99fcd3a1
2018-05-05 13:06:40 -07:00
android-build-prod (mdb)
e4a2c81ead Merge "Stubs libs are dist artifacts"
am: 11f12db823

Change-Id: I488a2fd27492e31cba05b28e64ba312b7a51d5a4
2018-05-05 07:17:36 -07:00