Commit Graph

11707 Commits

Author SHA1 Message Date
Alexander Smundak
439ef91ee5 Merge "Revert "Revert "Print full diagnostics file when Java process crashes."""
am: 22d3d6ba5c

Change-Id: I3a71d6df8a39a370acd13631960641ac0986e7b7
2019-06-04 12:47:50 -07:00
Treehugger Robot
22d3d6ba5c Merge "Revert "Revert "Print full diagnostics file when Java process crashes.""" 2019-06-04 17:16:10 +00:00
Colin Cross
5a927378ea Merge changes I88973671,If5a3b53a
am: 2406a123ba

Change-Id: Id7649534555602f7a3716d570ca88d93330fae75
2019-06-03 23:25:19 -07:00
Treehugger Robot
2406a123ba Merge changes I88973671,If5a3b53a
* changes:
  Fix nondeterminstic iteration of vndk modules map
  Fix data race and ordering consistency in apex modules
2019-06-04 06:10:00 +00:00
Ryan Prichard
b78d3c1b70 Merge "Omit .gnu_debuglink sections in object files"
am: e29e2473d2

Change-Id: I81dc36130b94bb8e0739c76c98392b6e07cec9c4
2019-06-03 16:29:29 -07:00
Ryan Prichard
e29e2473d2 Merge "Omit .gnu_debuglink sections in object files" 2019-06-03 23:15:38 +00:00
Colin Cross
4c2c46f0a7 Fix nondeterminstic iteration of vndk modules map
Sort the list of libraries when iterating over the vndk modules
map to avoid a non-deterministic output file.

Test: m nothing && mv out/soong/build.ninja /tmp && m nothing && diff -u out/soong/build.ninja /tmp/build.ninja
Change-Id: I889736715dab491bb7e69f3499ab1a5e2c876171
2019-06-03 15:52:27 -07:00
Colin Cross
cefa94bd27 Fix data race and ordering consistency in apex modules
apexDepsMutator can be called on multiple apex modules in parallel,
and then two goroutines could call BuildForApex on the same module
in parallel, leading to a data race appending to apexVariations.
This also results in random ordering of the entries in
apexVariations.

Hold a mutex around appending to apexVariations, and sort it before
passing it to ctx.CreateVariations.

Fixes: 134425751
Test: m nothing
Change-Id: If5a3b53a778daacb3e26ac05cde872cf8eb980b3
2019-06-03 15:52:27 -07:00
Alexander Smundak
b4be092855 Revert "Revert "Print full diagnostics file when Java process crashes.""
This reverts commit d71dc6b5e0.

Reason for revert: ag/974065 fixes the problem that caused the revert

Change-Id: I3ba9eecdab34602aaf19fa518520ac932c9b97af
2019-06-03 16:53:22 +00:00
Ryan Prichard
f979d73428 Omit .gnu_debuglink sections in object files
I'm not sure if these sections are used, but by adding them to
libgcc_stripped.a, we can end up with multiple .gnu_debuglink sections in
an executable, where the first two unhelpfully point at "libgcc.a". e.g.:

$ readelf -SW -x.gnu_debuglink out/target/product/walleye/system/bin/bootstrap/linker64
...

Section Headers:
  ...
  [18] .gnu_debuglink    PROGBITS        0000000000000000 10f19c 000020 00      0   0  1
  ...
  [22] .gnu_debuglink    PROGBITS        0000000000000000 18a2c8 000010 00      0   0  4
  ...

Hex dump of section '.gnu_debuglink':
  0x00000000 6c696267 63632e61 00000000 3d5f65d8 libgcc.a....=_e.
  0x00000010 6c696267 63632e61 00000000 3d5f65d8 libgcc.a....=_e.

Hex dump of section '.gnu_debuglink':
  0x00000000 6c696e6b 65723634 00000000 f85db7ea linker64.....]..

Bug: none
Test: m libgcc_stripped linker
Test: no .gnu_debuglink section in libgcc_stripped.a
Test: only one .gnu_debuglink section in system/bin/bootstrap/linker64
Change-Id: I0c47a9acd6d52f5cbc5bfa8b67d072ebb075a242
2019-05-31 15:07:16 -07:00
Jaewoong Jung
d41cf78501 Merge "Add data property to sh_test."
am: 06b2c69cfe

Change-Id: I31ff299bc84b6df8bc2336d1ddf2219e402ef1e0
2019-05-31 09:32:34 -07:00
Jaewoong Jung
06b2c69cfe Merge "Add data property to sh_test." 2019-05-31 16:05:42 +00:00
Dimitry Ivanov
441c715fe8 Merge "Skip native_bridge modules when installing vndk snapshot"
am: 656833e0c8

Change-Id: I51aea73275dc2e1e7d5fe01307a7eaca1918b74f
2019-05-31 06:07:26 -07:00
Dimitry Ivanov
656833e0c8 Merge "Skip native_bridge modules when installing vndk snapshot" 2019-05-31 12:51:55 +00:00
Alexander Smundak
62459d6586 Merge "Revert "Print full diagnostics file when Java process crashes.""
am: d5dd534465

Change-Id: Idc4b3e6985825669c0c473e80f0dca7e8b936baf
2019-05-31 02:51:35 -07:00
Treehugger Robot
d5dd534465 Merge "Revert "Print full diagnostics file when Java process crashes."" 2019-05-31 09:37:36 +00:00
patricktu
0fd9fb5299 Merge "AIDEGen: Collect the srcjar into out/soong/module_bp_java_deps.json"
am: b023fe382b

Change-Id: Iecbe23e5c5845fc3541583d1a81eb28a45f412f8
2019-05-30 22:42:49 -07:00
Treehugger Robot
b023fe382b Merge "AIDEGen: Collect the srcjar into out/soong/module_bp_java_deps.json" 2019-05-31 05:29:15 +00:00
Colin Cross
acb00184c3 Merge "Make test_options.timeout an int64"
am: 76acdadaf7

Change-Id: I8ca70f00056555feb95434a7ece28e1bb6604e2d
2019-05-30 20:18:58 -07:00
Alexander Smundak
d71dc6b5e0 Revert "Print full diagnostics file when Java process crashes."
This reverts commit 9d6df2246c.

Reason for revert: This change set the value of JAVA make variable to a string containing "foo bar". When soong_ui is asked to evaluate such string, it drops the quotes, causing bash to treat 'foo' and 'bar' as separate command line arguments.

Change-Id: If4e3c4c950c305bb67a572de3d86119c2da81dc1
2019-05-31 03:15:55 +00:00
Colin Cross
76acdadaf7 Merge "Make test_options.timeout an int64" 2019-05-31 03:11:22 +00:00
Jaewoong Jung
8eaeb0987d Add data property to sh_test.
Fixes: 131861785
Test: sh_binary_test.go, a real sh_test with added data
Change-Id: Ic78022d2db38a530074c70823ef16773d8ba6821
2019-05-30 17:21:29 -07:00
Mitch Phillips
a4fe1bccc9 Merge "Fix fuzzer builds [#2]."
am: a81760510d

Change-Id: I321565a10ce47661b3b8656cef9a1ea55af85414
2019-05-30 15:29:46 -07:00
Mitch Phillips
a81760510d Merge "Fix fuzzer builds [#2]." 2019-05-30 22:24:06 +00:00
Colin Cross
38ec6cfbf4 Merge "Port uses-shared library verification and dexpreopting to Soong"
am: 7a1fefc2de

Change-Id: Iae5fec127304a7b06e111a2d054347111dba3fac
2019-05-30 15:00:08 -07:00
Treehugger Robot
7a1fefc2de Merge "Port uses-shared library verification and dexpreopting to Soong" 2019-05-30 21:50:31 +00:00
Sasha Smundak
534d99369c Merge "Print full diagnostics file when Java process crashes."
am: 7b1ca80579

Change-Id: Ib3208a98f4e6a966c892f3b596b8bd8a525b67d7
2019-05-30 14:36:08 -07:00
Treehugger Robot
7b1ca80579 Merge "Print full diagnostics file when Java process crashes." 2019-05-30 21:16:52 +00:00
Colin Cross
2f9a7c8ab0 Make test_options.timeout an int64
I forgot we supported integer properties, use an integer instead
of a string for test_options.timeout.

Test: m checkbuild
Change-Id: I22d3135b31ec93d15b530c430b9e9cda6dd3f416
2019-05-30 11:19:32 -07:00
Mitch Phillips
bfeade6424 Fix fuzzer builds [#2].
- Updates the fuzzer builds to use SANITIZE_TARGET='fuzzer' instead of
'coverage'.
- Removed an old dependency that made fuzzer builds without ASan
an error.
- Fixed up the build flags to allow fuzzers to be built. Previously, the
coverage flags were manually provided. As the toolchain has moved on,
these flags are no longer compatible with libFuzzer, and so I've updated
them to use the correct, compatible flags.
- Added a dependency mutator for fuzzer coverage.

Bug: 121042685
Test: With all patches in the bug merged, build a fuzzer using
'SANITIZE_TARGET=fuzzer mmma <your_fuzzer>'.

Change-Id: Ib6246980f77bc4babe587b1e88038aa12228fa83
Merged-In: Ib6246980f77bc4babe587b1e88038aa12228fa83
2019-05-30 16:49:42 +00:00
Colin Cross
50ddcc4b69 Port uses-shared library verification and dexpreopting to Soong
Ports 09f3b97f4b488cd3a7b7d72038b173575b02c162 (Add support for
preopt with uses-libraries) from Make to Soong to support verifying
and preopting shared libraries.

This reapplies Id25f55f07a55120bebe2a9b32c094209efc85c8b with fixes
for unbundled builds and builds with ALLOW_MISSING_DEPENDENCIES=true
set.

Bug: 132357300
Test: app_test.go
Test: m checkbuild
Change-Id: I964309a68ec4ed081f3f3154879c71048ecb5455
2019-05-29 19:11:26 -07:00
Sasha Smundak
9d6df2246c Print full diagnostics file when Java process crashes.
Bug: 132766811
Test: treehugger
Change-Id: I8cca2486f2194a8643007a53e4a695d2a18abbf8
2019-05-29 17:46:22 -07:00
Colin Cross
cc50c0c4de Merge "Revert "Port uses-shared library verification and dexpreopting to Soong""
am: 7d06395f0c

Change-Id: Ieb207f98c88601f6857ed4ab996dfe850568975d
2019-05-29 13:47:12 -07:00
Colin Cross
7d06395f0c Merge "Revert "Port uses-shared library verification and dexpreopting to Soong"" 2019-05-29 20:34:10 +00:00
Colin Cross
c032498336 Revert "Port uses-shared library verification and dexpreopting to Soong"
This reverts commit b66d7b1c20.

Reason for revert: broke unbundled builds

Change-Id: I96ae287885107079de4a26e6b100ad8ed66961c0
2019-05-29 20:28:47 +00:00
Colin Cross
3c8e809052 Merge changes from topic "verify_uses_libraries"
am: 2f4c55e9f7

Change-Id: Id646d819bd33084f0f9f632cc5acd2106c05c234
2019-05-29 11:23:07 -07:00
Colin Cross
16eb45dfae Move verify_uses_libraries.sh out of dexpreopt
am: 38b968555c

Change-Id: I03c450b44d8b3e9d7293cd5d07e8b2506b7207be
2019-05-29 11:23:02 -07:00
Treehugger Robot
2f4c55e9f7 Merge changes from topic "verify_uses_libraries"
* changes:
  Port uses-shared library verification and dexpreopting to Soong
  Move verify_uses_libraries.sh out of dexpreopt
2019-05-29 18:09:01 +00:00
Martin Stjernholm
551438983b Merge "Allow //visibility:public to override other visibility rules."
am: 90e2eef512

Change-Id: I1f59deded1bc3d30cce88dd105460c3bf2c5064c
2019-05-29 08:58:06 -07:00
Martin Stjernholm
90e2eef512 Merge "Allow //visibility:public to override other visibility rules." 2019-05-29 15:46:34 +00:00
Tobias Thierer
9d4e40ea2d Merge "Support defaults properties in java_system_module"
am: 4b06c20215

Change-Id: I65b309705df745b5ea351f1a4af52e9675400f61
2019-05-29 04:21:31 -07:00
Tobias Thierer
4b06c20215 Merge "Support defaults properties in java_system_module" 2019-05-29 11:09:01 +00:00
Colin Cross
2d119ed870 Merge "Document escaping"
am: 89574e0c40

Change-Id: I5a86b42805964fe95e919a35e33ec7c8f9468d16
2019-05-28 18:34:27 -07:00
Colin Cross
89574e0c40 Merge "Document escaping" 2019-05-29 01:28:02 +00:00
Dan Willemsen
df12c1e44c Merge "Remove BUILD_BROKEN_ANDROIDMK_EXPORTS"
am: 20272e1480

Change-Id: I38475ac01867e6c11c40f8526797ddf87968272f
2019-05-28 18:25:35 -07:00
Colin Cross
4bccc0801c Don't build hiddenapi flags or encode dex for unbundled builds
am: 9c74a1ee85

Change-Id: I80ff83a49c809b867acdc2765376da39b1bac70e
2019-05-28 18:25:06 -07:00
Treehugger Robot
20272e1480 Merge "Remove BUILD_BROKEN_ANDROIDMK_EXPORTS" 2019-05-29 01:17:01 +00:00
Colin Cross
9c74a1ee85 Don't build hiddenapi flags or encode dex for unbundled builds
Builds with TARGET_BUILD_APPS shouldn't build the hiddenapi flags
or encode dex files even if frameworks/base exists.

Bug: 133343287
Test: mainline modules build
Change-Id: I0647451420fd09bb680808b35e1ad3b8f514ba46
2019-05-28 21:48:54 +00:00
Colin Cross
667ffa192f Support defaults properties in java_system_module
Test: none
Change-Id: I08e5c39690b3c9960dc5e99c4b866a2523c9eafb
2019-05-28 20:36:46 +00:00
Colin Cross
b66d7b1c20 Port uses-shared library verification and dexpreopting to Soong
Ports 09f3b97f4b488cd3a7b7d72038b173575b02c162 (Add support for
preopt with uses-libraries) from Make to Soong to support verifying
and preopting shared libraries.

Bug: 132357300
Test: app_test.go
Test: m checkbuild
Change-Id: Id25f55f07a55120bebe2a9b32c094209efc85c8b
2019-05-28 11:20:09 -07:00