Jingwen Chen
c1b6478f5e
Add a mutex for soong config var map writes. am: 4ad40d99b0
am: efb5654552
am: 1b91d4be89
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1901432
Change-Id: I2c1ed764c35a2ca3d962408ce785ad3225d501f0
2021-11-24 12:56:00 +00:00
Jingwen Chen
1b91d4be89
Add a mutex for soong config var map writes. am: 4ad40d99b0
am: efb5654552
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1901432
Change-Id: I97d78c6f562b28003a9953b84bd89b4a404c98c6
2021-11-24 12:45:33 +00:00
Jingwen Chen
efb5654552
Add a mutex for soong config var map writes. am: 4ad40d99b0
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1901432
Change-Id: I80083220c1e06854c98b1a5aa96cddd944b5b181
2021-11-24 12:28:15 +00:00
Jingwen Chen
4ad40d99b0
Add a mutex for soong config var map writes.
...
Fixes: 207572723
Test: CI
Change-Id: Ide4ca9961b8615186c3ab703c461b6ef53ef656e
2021-11-24 03:42:35 +00:00
Martin Stjernholm
3514941226
Don't pass ":=" in variable name to AndroidMkEntries.SetString. am: ae44fd8032
am: 7263046919
am: 471116c036
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1900777
Change-Id: Ia9305a4a9746c8fa33e5e7e472f339a2bbfa5b13
2021-11-24 03:15:30 +00:00
Martin Stjernholm
471116c036
Don't pass ":=" in variable name to AndroidMkEntries.SetString. am: ae44fd8032
am: 7263046919
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1900777
Change-Id: If398fd25ce0465e13af6d31d84579c162a3078e4
2021-11-24 03:05:22 +00:00
Martin Stjernholm
7263046919
Don't pass ":=" in variable name to AndroidMkEntries.SetString. am: ae44fd8032
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1900777
Change-Id: I0f13bd89411e62a874d10f20f7b970d5f63edd23
2021-11-24 02:44:21 +00:00
Martin Stjernholm
ae44fd8032
Don't pass ":=" in variable name to AndroidMkEntries.SetString.
...
Fixes typos in https://r.android.com/1897972 .
Test: m SOONG_CONFIG_art_module_source_build=false nothing
Bug: 204136549
Change-Id: I768c21bc99bfb4978fcf7f4f3631eef866e76764
2021-11-23 23:17:33 +00:00
Treehugger Robot
cf715e6327
Merge "Account for "validations:"" am: b5f81d2a6a
am: 3996eb1a77
am: d1e248c441
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1901170
Change-Id: Ib57f50172e27e751e953e42ed4300e954a606e03
2021-11-23 22:54:08 +00:00
Treehugger Robot
d1e248c441
Merge "Account for "validations:"" am: b5f81d2a6a
am: 3996eb1a77
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1901170
Change-Id: I8d9eaa5da317c068d09cabf9aa08f27a292f503b
2021-11-23 22:43:55 +00:00
Treehugger Robot
3996eb1a77
Merge "Account for "validations:"" am: b5f81d2a6a
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1901170
Change-Id: Ia6eb5b35de865b5f421e37db31186ce8c4fdfac9
2021-11-23 22:30:41 +00:00
Treehugger Robot
b5f81d2a6a
Merge "Account for "validations:""
2021-11-23 22:12:26 +00:00
Cole Faust
2a6b9903d2
Merge "Print product vars in board config launcher" am: b3b28012b9
am: 2733063fb5
am: 7e2958a3e5
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1899999
Change-Id: Ia253230f36121c8fc3ca299f20dab2fdf59a93b8
2021-11-23 21:32:37 +00:00
Cole Faust
7e2958a3e5
Merge "Print product vars in board config launcher" am: b3b28012b9
am: 2733063fb5
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1899999
Change-Id: I7c0466cf3d02efd66f7e65d5cc5bc0f42827a7a9
2021-11-23 21:22:21 +00:00
Cole Faust
2733063fb5
Merge "Print product vars in board config launcher" am: b3b28012b9
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1899999
Change-Id: I9a8b2bf84c587a7de96a43201d52b8338a1becef
2021-11-23 21:04:06 +00:00
Cole Faust
b3b28012b9
Merge "Print product vars in board config launcher"
2021-11-23 20:46:45 +00:00
Bob Badour
0174ae3ae0
Account for "validations:"
...
Change-Id: I72b188c8cac54aa59d31e91b2a03b1329384e686
2021-11-23 12:12:06 -08:00
Sophie Zheng
6e6b076f1e
Merge "NDK API coverage" am: 1469ff6ece
am: 0ea8eee571
am: b2e9e69499
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1899591
Change-Id: I9df701f312c9df9f787d6f52bdaa70392f849381
2021-11-23 18:31:38 +00:00
Sophie Zheng
b2e9e69499
Merge "NDK API coverage" am: 1469ff6ece
am: 0ea8eee571
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1899591
Change-Id: Ic2197183b470ed971435e67269b09983f49a80fa
2021-11-23 18:16:14 +00:00
Sophie Zheng
0ea8eee571
Merge "NDK API coverage" am: 1469ff6ece
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1899591
Change-Id: I697186301749c0bd8a79c2122506dd6e6d026917
2021-11-23 17:57:45 +00:00
Sophie Zheng
1469ff6ece
Merge "NDK API coverage"
2021-11-23 17:38:08 +00:00
Jingwen Chen
9e4d384ebc
Temporarily disable //system/apex from bp2build due to flaky failures. am: d43d4a4cdf
am: f7251d4557
am: 43ca1ac2a4
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1899160
Change-Id: Ib2ef523a1a396d02d21153ddd3b19971b4363295
2021-11-23 15:36:31 +00:00
Jingwen Chen
43ca1ac2a4
Temporarily disable //system/apex from bp2build due to flaky failures. am: d43d4a4cdf
am: f7251d4557
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1899160
Change-Id: I9ec63659ee167b854f9153ff2e4e53a25b04db2e
2021-11-23 15:22:12 +00:00
Jingwen Chen
f7251d4557
Temporarily disable //system/apex from bp2build due to flaky failures. am: d43d4a4cdf
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1899160
Change-Id: If5a296688c930972dc7edf8223caf4b703318708
2021-11-23 15:03:46 +00:00
Jingwen Chen
d43d4a4cdf
Temporarily disable //system/apex from bp2build due to flaky failures.
...
Bug: 207466993
Test: CI
Change-Id: Ie8fad3e34113e037271cd9f869babe7630d434ad
2021-11-23 12:41:17 +00:00
Jingwen Chen
13025fe63c
Add support for writing all Soong config variables into @soong_injection. am: 01812020c1
am: 096249a5b0
am: 67cc81d9a4
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1895250
Change-Id: I19adaca90ddba9dda6989129686b1a416d7c6bf4
2021-11-23 12:27:05 +00:00
Jingwen Chen
c71a9482c5
Fix bp2build select generation for inter-attribute soong config am: 58ff6801f4
am: d4c0c1fc12
am: 19de6d49ea
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1894968
Change-Id: I207b7b63629e42a9df37db345801b0a4db3e8b2d
2021-11-23 12:27:04 +00:00
Jingwen Chen
e12de38b7c
Allowlist //system/apex. am: 228ef1e370
am: f05d2e8dcd
am: 0eb455be0c
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1894967
Change-Id: I35778ecabc5ddfa0d6f901b01f6aefcfac776901
2021-11-23 12:27:03 +00:00
Jingwen Chen
43e834945b
Add support for merging defaults soong_config_module_types into bp2build am: 84817de033
am: 03eb2b1774
am: 07415f907f
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1894966
Change-Id: If726a8e907ec715d970ce77acd7fa6548a6f73d3
2021-11-23 12:27:02 +00:00
Jingwen Chen
67cc81d9a4
Add support for writing all Soong config variables into @soong_injection. am: 01812020c1
am: 096249a5b0
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1895250
Change-Id: Iaa9e9a0c083884708bc512c3c11a36b37bb2323b
2021-11-23 12:14:35 +00:00
Jingwen Chen
19de6d49ea
Fix bp2build select generation for inter-attribute soong config am: 58ff6801f4
am: d4c0c1fc12
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1894968
Change-Id: Ic81dce3ae9743354a7499e0e2aca5d11f8e928db
2021-11-23 12:14:34 +00:00
Jingwen Chen
0eb455be0c
Allowlist //system/apex. am: 228ef1e370
am: f05d2e8dcd
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1894967
Change-Id: Ibdbe7597a2db676bf9e2faf91100afab8f50a11a
2021-11-23 12:14:33 +00:00
Jingwen Chen
07415f907f
Add support for merging defaults soong_config_module_types into bp2build am: 84817de033
am: 03eb2b1774
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1894966
Change-Id: Ib5bd001b5eb4c267e67a69bb2df483f2cff8e7f2
2021-11-23 12:14:32 +00:00
Jingwen Chen
096249a5b0
Add support for writing all Soong config variables into @soong_injection. am: 01812020c1
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1895250
Change-Id: I159ae4fb71613ea457abc651cf705e5d0d168f18
2021-11-23 12:03:40 +00:00
Jingwen Chen
d4c0c1fc12
Fix bp2build select generation for inter-attribute soong config am: 58ff6801f4
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1894968
Change-Id: I84e534ebf6e35300a9eccd3f8330bf6932692782
2021-11-23 12:03:40 +00:00
Jingwen Chen
f05d2e8dcd
Allowlist //system/apex. am: 228ef1e370
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1894967
Change-Id: I3d2467ea4b8dd797e7d1354ad99684e5b8bc72d5
2021-11-23 12:03:39 +00:00
Jingwen Chen
03eb2b1774
Add support for merging defaults soong_config_module_types into bp2build am: 84817de033
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1894966
Change-Id: I23f971d1f02c0c7547ed372afb77be65238bd649
2021-11-23 12:03:38 +00:00
Jingwen Chen
01812020c1
Add support for writing all Soong config variables into @soong_injection.
...
Also remove the need to use bp2build_available on
soong_config_module_types as we want to convert every single of them
into the tree for a complete soong_injection soong_config_variables.bzl
file.
The variables are split into their bool, value and string types
respectively, as they all need to be handled differently on the Bazel
product_platform side, as well as for generating constraint values and
settings. For example, value variables need to integrate with
TemplateVariableInfo, and string variables need to include the string
value itself into the select key/constraint value.
Sample soong_config_variables.bzl file: https://gist.github.com/jin/cef700bfb20c8656a931306dd71d47e1
Test: CI
Bug: 198556411
Change-Id: I8665dd1269a507edb37de62407ed3641564bea5c
2021-11-23 08:37:30 +00:00
Jingwen Chen
58ff6801f4
Fix bp2build select generation for inter-attribute soong config
...
variable usage.
There's bug a in the current soong_config_variable handling
implementation where a soong_config_variable sets conditions_default
value for an attr, and a non-conditions_default value for another attr.
This results in the former attr not properly setting the zero value for
the non-conditions_default select key, resulting in the pretty printer
omitting the attribute totally.
The current implementation in this CL ensures that the zero value is set
whenever this happens at the module level. This is seen in
library_linking_strategy_cc_defaults (see comments in code, and the new
tests)
Test: CI
Bug: 198556411
Change-Id: Ibaeb94508c51a7429fb7a08df610cbb5470f76d2
2021-11-23 08:37:30 +00:00
Jingwen Chen
228ef1e370
Allowlist //system/apex.
...
This bp2builds the one cc_binary in that package that uses
library_linking_strategy_cc_defaults. That target is buildable, but
there's still a bp2build_available allowlist bug that causes the select
statements and static_libs deps to not show up for the target (only
dynamic_deps are), due to how bp2build_available is special cased for
soong_config_module_type in the loadhook.
Test: b build //system/apex:library_linking_strategy_sample_binary
Change-Id: Ic38a1bfaa476108db63348d030e196d8561300ca
2021-11-23 08:37:30 +00:00
Jingwen Chen
84817de033
Add support for merging defaults soong_config_module_types into bp2build
...
select statements.
This supports defaults from the same or different namespaces, and
transitively defaults as well.
Test: soong unit tests
Test: CI
Change-Id: I99435bacfcfbfe20ad753b8021a1779531d7595a
2021-11-23 08:37:30 +00:00
Jack Yu
9438c79bb0
Merge "Support for OMAPI Vendor stable interface" am: bc07b0c67e
am: 87bf97ac19
am: 1eecb9e3aa
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1826613
Change-Id: Ib708ee8ba502794fc42163ad93a09187f870fa17
2021-11-23 05:41:56 +00:00
Jack Yu
1eecb9e3aa
Merge "Support for OMAPI Vendor stable interface" am: bc07b0c67e
am: 87bf97ac19
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1826613
Change-Id: I6a96aba364125c3250ebe90e8e1ebebf1e078748
2021-11-23 05:29:46 +00:00
Jack Yu
87bf97ac19
Merge "Support for OMAPI Vendor stable interface" am: bc07b0c67e
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1826613
Change-Id: Ie1c349f2669996d42575c653feecb51092335d95
2021-11-23 05:13:43 +00:00
Jack Yu
bc07b0c67e
Merge "Support for OMAPI Vendor stable interface"
2021-11-23 04:54:02 +00:00
Jooyung Han
7fb5afdd2a
Remove libsync from apex_available allowlist am: 9876c5eaab
am: 6f323db66b
am: 57440917f1
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1899132
Change-Id: I0e8974e86c6dfac26995ba8436247a46e309d389
2021-11-23 04:36:14 +00:00
Jooyung Han
57440917f1
Remove libsync from apex_available allowlist am: 9876c5eaab
am: 6f323db66b
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1899132
Change-Id: Ie3f69998a52d5bce07a7cfcd8ca157d45677deb2
2021-11-23 04:26:44 +00:00
Jooyung Han
6f323db66b
Remove libsync from apex_available allowlist am: 9876c5eaab
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1899132
Change-Id: Iaee7a4e7a72787d0c53da216d33b3c3ad8879f7d
2021-11-23 04:09:41 +00:00
Jooyung Han
9876c5eaab
Remove libsync from apex_available allowlist
...
As libsync is NDK/LLNDK, it doesn't need to be aded to allowlist as
apex_available.
Bug: n/a
Test: m
Change-Id: I16cfb258a24bde4def428f1e6277f5d3c95c228c
2021-11-23 11:06:16 +09:00
Cole Faust
3c1868bbcc
Print product vars in board config launcher
...
Bug: 201700692
Test: ./build/bazel/ci/rbc_regression_test.sh -b aosp_cf_x86_64_phone-userdebug
Change-Id: I1d3f6f13fc662807db2a86d1daffcc81433d82fc
2021-11-22 16:34:11 -08:00