Commit Graph

85671 Commits

Author SHA1 Message Date
Cole Faust
a2847f62d2 Rename ConfigAndErrorContext to ConfigurableEvaluatorContext am: e8a8783154 am: 7e167d1516
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/3263043

Change-Id: I1846d97a9d93b5c80c0f14e9f6f081e358457162
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-11 20:42:25 +00:00
Cole Faust
7e167d1516 Rename ConfigAndErrorContext to ConfigurableEvaluatorContext am: e8a8783154
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/3263043

Change-Id: I105e027ba65507285c5850a1b6367944b72d3625
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-11 20:30:31 +00:00
Cole Faust
e8a8783154 Rename ConfigAndErrorContext to ConfigurableEvaluatorContext
I'm going to be adding some methods to this interface, give it
a name based on how it's going to be used, not based on what methods
it contains.

Bug: 323382414
Test: m nothing --no-skip-soong-tests
Change-Id: I9bba04ba756c4dbe00625e2d04af81e78a11cae9
2024-09-11 11:35:46 -07:00
Krzysztof Kosiński
372247c264 Merge "Add missing pieces of ARMv9.2-A support." into main am: 28b806c9eb am: cab8f1278f
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/3258911

Change-Id: Ida4d3c5c30928ab198f40766789890c3c5c97eb4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-11 16:26:18 +00:00
Krzysztof Kosiński
cab8f1278f Merge "Add missing pieces of ARMv9.2-A support." into main am: 28b806c9eb
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/3258911

Change-Id: I11ce8a7d8a884b59478485b5b80ce2e74bbadb22
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-11 16:17:42 +00:00
Krzysztof Kosiński
28b806c9eb Merge "Add missing pieces of ARMv9.2-A support." into main 2024-09-11 16:04:44 +00:00
Neill Kapron
82791152bd Merge "SOONG: BPF: add libbpf_prog soong module" into main am: f1d63b8b6d am: 2b4699841d
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/3202693

Change-Id: I581050f515256b634e94d75a65b7489545ccf0ed
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-11 15:53:47 +00:00
Neill Kapron
2b4699841d Merge "SOONG: BPF: add libbpf_prog soong module" into main am: f1d63b8b6d
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/3202693

Change-Id: I6007e73b5dea1d1766f4ddebeee26c63a3e6c398
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-11 15:44:23 +00:00
Neill Kapron
f1d63b8b6d Merge "SOONG: BPF: add libbpf_prog soong module" into main 2024-09-11 15:41:14 +00:00
Treehugger Robot
3dbfab1d91 Merge "Rerun globs when a dependency is missing" into main am: 1705fef470 am: cc7d4a76b1
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/3263539

Change-Id: If490e4859509ac76fbc453900e3726e07cc13ec6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-11 05:43:20 +00:00
Treehugger Robot
cc7d4a76b1 Merge "Rerun globs when a dependency is missing" into main am: 1705fef470
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/3263539

Change-Id: Ic71ccf0c745b3cf32bbc314d33f2162d9ca8e0c3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-11 05:33:44 +00:00
Treehugger Robot
1705fef470 Merge "Rerun globs when a dependency is missing" into main 2024-09-11 05:30:14 +00:00
Jim Tang
1c0a7e9ef7 Merge "Support apk for product_variables.debuggable" into main am: 01c3234190 am: d39ad81a6b
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/3261653

Change-Id: I1986f86101caa4d502895eb1f31d295416b2b954
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-11 03:09:02 +00:00
Jim Tang
d39ad81a6b Merge "Support apk for product_variables.debuggable" into main am: 01c3234190
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/3261653

Change-Id: If0b95542b6d73998c0c13b8a62def34096259a74
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-11 03:00:26 +00:00
Jim Tang
01c3234190 Merge "Support apk for product_variables.debuggable" into main 2024-09-11 02:56:11 +00:00
Cole Faust
69c78e9b6e Rerun globs when a dependency is missing
If you remove a folder that's part of a glob, soong will error out
currently. Instead treat it like an out-of-date dependency.

Bug: 364749114
Test: m nothing, rm glob folder, m nothing
Change-Id: I86ee755a0815b79192133223f8ef3ecd90669db1
2024-09-10 16:46:06 -07:00
Cole Faust
6f4aefd1e0 Merge "Make globs compatible with hash-based ninja semantics" into main am: 8ca2a80d27 am: ff8decd0f4
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/3260638

Change-Id: Iec761f33788e4a9228bd3cb0e8042b2eda067d89
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-10 23:34:23 +00:00
Cole Faust
ff8decd0f4 Merge "Make globs compatible with hash-based ninja semantics" into main am: 8ca2a80d27
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/3260638

Change-Id: I55df1aaaf7946de1c174e71a8285e60a4413d8f2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-10 23:24:54 +00:00
Cole Faust
8ca2a80d27 Merge "Make globs compatible with hash-based ninja semantics" into main 2024-09-10 23:20:10 +00:00
Treehugger Robot
544aa6f1ec Merge "Add a check for -fno-integrated-as" into main am: e97ec10a98 am: c8321f8bb3
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/3249130

Change-Id: I98f34407d78ad730b779fd108bb6f280e288c246
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-10 21:00:17 +00:00
Treehugger Robot
c8321f8bb3 Merge "Add a check for -fno-integrated-as" into main am: e97ec10a98
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/3249130

Change-Id: I30e9d8d5ca845e07a48ed46bb0ea418276811573
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-10 20:49:56 +00:00
Treehugger Robot
e97ec10a98 Merge "Add a check for -fno-integrated-as" into main 2024-09-10 20:38:55 +00:00
Cole Faust
3ec447b668 Merge "Remove BUILD_BROKEN_USES_SOONG_PYTHON2_MODULES" into main am: dd46300414 am: 0776ae425d
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/3261492

Change-Id: I2045d6f00a14f2d04cd8628ef11a105fc41cef40
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-10 19:42:33 +00:00
Treehugger Robot
6e00bfbb16 Merge "Revert "Add BUILD_BROKEN_PYTHON_IS_PYTHON2"" into main am: 864344a84f am: 1caf5ca0e6
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/3261355

Change-Id: If18625d42160c96f1023e8e61c8475c10e41677f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-10 19:42:10 +00:00
Cole Faust
0776ae425d Merge "Remove BUILD_BROKEN_USES_SOONG_PYTHON2_MODULES" into main am: dd46300414
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/3261492

Change-Id: Idbe35cb1b056579372c6bbfdeab85ebd0154fc7d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-10 19:34:15 +00:00
Cole Faust
dd46300414 Merge "Remove BUILD_BROKEN_USES_SOONG_PYTHON2_MODULES" into main 2024-09-10 19:33:04 +00:00
Treehugger Robot
1caf5ca0e6 Merge "Revert "Add BUILD_BROKEN_PYTHON_IS_PYTHON2"" into main am: 864344a84f
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/3261355

Change-Id: Ib4c93762c49698cea20be7292b7b3000979c349d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-10 19:32:56 +00:00
Treehugger Robot
864344a84f Merge "Revert "Add BUILD_BROKEN_PYTHON_IS_PYTHON2"" into main 2024-09-10 19:24:10 +00:00
Treehugger Robot
8965459014 Merge "Improve docs about //visibility:public" into main am: 2545872a68 am: c8a2c341af
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/3257954

Change-Id: I97d4e3b55e1dfed188f7845f3139ddeb33c399ee
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-10 19:04:00 +00:00
Treehugger Robot
c8a2c341af Merge "Improve docs about //visibility:public" into main am: 2545872a68
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/3257954

Change-Id: Ie1ddc06dd2721b825534f67d7bef2fe7187030c4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-10 18:54:01 +00:00
Treehugger Robot
2545872a68 Merge "Improve docs about //visibility:public" into main 2024-09-10 18:48:06 +00:00
Spandan Das
8a847c409c Improve docs about //visibility:public
https://r.android.com/3252814 modified the visibility to
//visibility:public to account for visibility skew between development
and release branches.

Drop the comment about stub libraries being safe to use by any _rdep_.
There might be cases where this is not true.

Test: N/A
Bug: 239189932
Change-Id: I74ca661a40384d480148f5e18f76495e837c58e3
2024-09-10 17:51:36 +00:00
Treehugger Robot
6f67fe16ae Merge "Sandbox com.google.pixel.camera.hal.manifest" into main am: 58e82f6c9c am: 8f077d96f9
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/3260062

Change-Id: I859590cd91c108c1d099ce76bf133a7d9ad35615
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-10 17:48:21 +00:00
Treehugger Robot
8f077d96f9 Merge "Sandbox com.google.pixel.camera.hal.manifest" into main am: 58e82f6c9c
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/3260062

Change-Id: I68875233b6f8c641aa53a8c3c31a785e906b0d56
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-10 17:38:18 +00:00
Treehugger Robot
58e82f6c9c Merge "Sandbox com.google.pixel.camera.hal.manifest" into main 2024-09-10 17:29:40 +00:00
Cole Faust
527dc30f42 Revert "Add BUILD_BROKEN_PYTHON_IS_PYTHON2"
This reverts commit b1fbc79206.

Removing the build broken flag to progress the python3 migration. It's been here for over a year and I haven't heard of any users.

Bug: 203436762
Test: Presubmits
Change-Id: Icfd2d25986abda934c60fd868ed5525dc384fbf3
2024-09-10 10:04:19 -07:00
Jim Tang
914832444e Support apk for product_variables.debuggable
Bug: 365707065
Test: m FactoryOtaPrebuilt
Change-Id: I880b9d48b52d49cbf8c1eca6a67d3ffadc8ea0fc
2024-09-10 18:06:22 +08:00
Treehugger Robot
fad576fab8 Merge "Update $PRODUCT_OUT from the soong system image files" into main am: 3507a28d75 am: 88a81fe2f9
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/3247732

Change-Id: I0c047a0d0b9d9a14139b614278de760b759c710c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-10 01:48:24 +00:00
Treehugger Robot
88a81fe2f9 Merge "Update $PRODUCT_OUT from the soong system image files" into main am: 3507a28d75
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/3247732

Change-Id: If8969c2a5aa4d5b2aee7ec9f165af31419eaa4b7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-10 01:38:53 +00:00
Treehugger Robot
3507a28d75 Merge "Update $PRODUCT_OUT from the soong system image files" into main 2024-09-10 01:27:05 +00:00
Cole Faust
4ce4f8893e Remove BUILD_BROKEN_USES_SOONG_PYTHON2_MODULES
It's been available for over a year, lets progress the python3 migration
by removing it.

Bug: 203436762
Test: Presubmits
Change-Id: I46a6477ec65e98b7e6df5cc1359f676dcbd0f08e
2024-09-09 18:08:49 -07:00
Treehugger Robot
4767e005ae Merge "Remove zeros from build number" into main am: 47d151befe am: a8d03ebc80
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/3260641

Change-Id: I41794556942fbbe6d5de8fc86e99f326ca7b4142
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-10 01:06:35 +00:00
Treehugger Robot
a8d03ebc80 Merge "Remove zeros from build number" into main am: 47d151befe
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/3260641

Change-Id: Idc70c7810f90c4c0b167526e7e180f288cf58472
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-10 00:55:06 +00:00
Treehugger Robot
47d151befe Merge "Remove zeros from build number" into main 2024-09-10 00:52:26 +00:00
Cole Faust
2fec4128e0 Make globs compatible with hash-based ninja semantics
Previously, globs worked by having soong_build rewrite a ninja file
that ran the globs, and then dependended on the results of that ninja
file. soong_build also pre-filled their outputs so that it wouldn't
be immediately rerun on the 2nd build.

However, the pre-filling of outputs worked for ninja, because although
it updated their timestamps, the soong ninja file was then touched
by soong_build after that, so the soong_build ninja file was newer
and ninja wouldn't rerun soong. But N2 reruns actions if their inputs'
mtimes change in any way, not just if they're newer. Similarly,
hashed-based ninja implementations could not enforce an order on
file contents, so they would have the same problem.

To fix this, lift the glob checking out of ninja and into soong_ui.
Soong_build will output a globs report file every time it's run, and
every time soong_ui is run it will check the globs file, and if any
globs change, update an input to soong_build. soong_ui is essentially
doing what was done in ninja with bpglob actions before.

Bug: 364749114
Test: m nothing, m nothing again doesn't reanalyze, create a new file under a glob directory, m nothing again reanalyzes
Change-Id: I0dbc5ec58c89b869b59cd0602b82215c4972d799
2024-09-09 17:42:49 -07:00
Spandan Das
cea4f96853 Remove extra space in error message am: ca9ccec822 am: b6d261875b
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/3261293

Change-Id: Iaebeb88ccb692696bcb9cf2c4c25eba0afcb4fce
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-10 00:23:09 +00:00
Spandan Das
b6d261875b Remove extra space in error message am: ca9ccec822
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/3261293

Change-Id: If8d44188efa96217e1c592665fb0570a6d0ece67
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-10 00:13:18 +00:00
Cole Faust
3ae36f42dc Remove zeros from build number
The zeros were kept in place of the timestamp in case people were
parsing it. Let's try to remove the zeros now and see what breaks.

Test: Presubmits
Change-Id: Ic52168f6be05a74323d8e47935de5c6a5cf15516
2024-09-09 16:54:16 -07:00
Cole Faust
65922b20fa Sandbox com.google.pixel.camera.hal.manifest
It's now taking advantage of the uses_order_only_build_number_file
feature of genrules, and doesn't need to be excempted from sandboxing.

Bug: 307824623
Test: Presubmits
Change-Id: I6ae5da7518990fbf4083aeac1aaba770210a4be1
2024-09-09 16:50:37 -07:00
Spandan Das
ca9ccec822 Remove extra space in error message
Change-Id: I45420afc37736ec8fecd0c489c35c14b377a71a5
Test: N/A
2024-09-09 22:58:11 +00:00